[FFmpeg-devel] [PATCH]nvenc: Add capability check for Temporal AQ

[Sven C. Dack]

On 19/10/16 12:00, Hendrik Leppkes wrote:
> On Wed, Oct 19, 2016 at 12:20 PM, Sven C. Dack <sven.c.dack at sky.com> wrote:
>> On 19/10/16 11:01, Yogender Kumar Gupta wrote:
>>>>> I've send in 3 patches regarding Nvidia stuff (1. check for temp aq, 2.
>>> option for temp aq in hevc, 3. limitation work-around for scale npp), but
>>> there seems to be no maintainer present at the moment to pick them up...
>>>
>>> Tempoal AQ HEVC not supported yet.
>>>
>> I cannot confirm. On some hardware it isn't, yes, but I don't own all Pascal
>> cards
> All Pascal cards (releases so far) have the same hardware encoding block.

Temporal AQ is implemented in CUDA, not in silicon. So far does the API (Video 
SDK 7.0.1) accept the flag without giving any errors. The output however remains 
identical currently (tested on a GTX 960). You'll have to ask Nvidia why they 
haven't implemented it yet (i'ts probably too soon). I am expecting it to become 
available with a future driver (or SDK or CUDA). It's already available for 
NVENC when encoding H.264/AVC and it's not only a method used in H.264 encoding, 
but one which is used in H.265 encoding, too (for example does x265 call auto 
variance '--aq-mode 2').

Unless you can give good reasons why not to provide the flag do I not see why to 
hide it from users when it's already in the API and exists as a feature test.