[FFmpeg-devel] [PATCH]nvenc: Add capability check for Temporal AQ

[Hendrik Leppkes]

On Wed, Oct 19, 2016 at 1:30 PM, Sven C. Dack <sven.c.dack at sky.com> wrote:
> On 19/10/16 12:00, Hendrik Leppkes wrote:
>>
>> On Wed, Oct 19, 2016 at 12:20 PM, Sven C. Dack <sven.c.dack at sky.com>
>> wrote:
>>>
>>> On 19/10/16 11:01, Yogender Kumar Gupta wrote:
>>>>>>
>>>>>> I've send in 3 patches regarding Nvidia stuff (1. check for temp aq,
>>>>>> 2.
>>>>
>>>> option for temp aq in hevc, 3. limitation work-around for scale npp),
>>>> but
>>>> there seems to be no maintainer present at the moment to pick them up...
>>>>
>>>> Tempoal AQ HEVC not supported yet.
>>>>
>>> I cannot confirm. On some hardware it isn't, yes, but I don't own all
>>> Pascal
>>> cards
>>
>> All Pascal cards (releases so far) have the same hardware encoding block.
>
>
> Temporal AQ is implemented in CUDA, not in silicon.

Well you commented on hardware, so.

> Unless you can give good reasons why not to provide the flag do I not see
> why to hide it from users when it's already in the API and exists as a
> feature test.
>

If its entirely untested (due to being unsupported), it should not be
made available, and instead be added once it is supported and has been
confirmed to be working properly.
There is also no reason to add it if we know it doesn't work, it would
just be misleading to add an option, which then shows up in the help
output, if we already know it doesnt work anywhere (yet).

- Hendrik