[FFmpeg-devel] [PATCH 1/8] compat/cuda: add dynamic loader

[Sven C. Dack]

On 19/10/16 13:50, Hendrik Leppkes wrote:
> On Wed, Oct 19, 2016 at 2:00 PM, Timo Rothenpieler
> <timo at rothenpieler.org> wrote:
>> ---
>>   compat/cuda/dynlink_cuda.h     |  88 +++++
>>   compat/cuda/dynlink_cuviddec.h | 808 +++++++++++++++++++++++++++++++++++++++++
>>   compat/cuda/dynlink_loader.h   | 254 +++++++++++++
>>   compat/cuda/dynlink_nvcuvid.h  | 316 ++++++++++++++++
>>   4 files changed, 1466 insertions(+)
>>   create mode 100644 compat/cuda/dynlink_cuda.h
>>   create mode 100644 compat/cuda/dynlink_cuviddec.h
>>   create mode 100644 compat/cuda/dynlink_loader.h
>>   create mode 100644 compat/cuda/dynlink_nvcuvid.h
>>
>> diff --git a/compat/cuda/dynlink_cuda.h b/compat/cuda/dynlink_cuda.h
>> new file mode 100644
>> index 0000000..908f12d
>> --- /dev/null
>> +++ b/compat/cuda/dynlink_cuda.h
>> @@ -0,0 +1,88 @@
>> +/*
>> + * This file is part of FFmpeg.
>> + *
>> + * FFmpeg is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU Lesser General Public
>> + * License as published by the Free Software Foundation; either
>> + * version 2.1 of the License, or (at your option) any later version.
>> + *
>> + * FFmpeg is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> + * Lesser General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU Lesser General Public
>> + * License along with FFmpeg; if not, write to the Free Software
>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>> + */
> So did you write this without once looking at the NVIDIA header file?
> Because if you did even read it, then you can't realistically claim
> this is LGPL.

Nvidia's copyright notice seem pretty clear to me. It grants permission to 
sublicense it without limitation and without restriction. So which part exactly 
in Nvidia's copyright notice do you have a problem with?

PS: Try not to reply with the entire patch, but cut it off. It's not fun to 
scroll through the entire reply just to find it contains 2-3 lines of comment.

>> +/*
>> + * This copyright notice applies to this header file only:
>> + *
>> + * Copyright (c) 2010-2016 NVIDIA Corporation
>> + *
>> + * Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or sell
>> + * copies of the software, and to permit persons to whom the
>> + * software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +
>> +/**
>> + * \file cuviddec.h
>> + * NvCuvid API provides Video Decoding interface to NVIDIA GPU devices.
>> + * \date 2015-2016
>> + * This file contains constants, structure definitions and function prototypes used for decoding.
>> + */