[FFmpeg-devel] [PATCH] lavf/mov.c: Use the first sidx for tracks without sidx.

Sasi Inguva isasi at google.com
Wed Oct 26 21:30:30 EEST 2016


sorry. forgot to remove the debug printf. sending the corrected  patch.

On Wed, Oct 26, 2016 at 7:47 AM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> On Tue, Oct 25, 2016 at 11:07:58PM -0700, Sasi Inguva wrote:
> > According to spec ISO_IEC_15444_12 "For any media stream for which no
> segment index is present, referred to as non‐indexed stream, the media
> stream associated with the first Segment Index box in the segment serves as
> a reference stream in a sense that it also describes the subsegments for
> any non‐indexed media stream."
> >
> > Signed-off-by: Sasi Inguva <isasi at google.com>
> > ---
> >  libavformat/isom.h |  1 +
> >  libavformat/mov.c  | 26 +++++++++++++++++++++++---
> >  2 files changed, 24 insertions(+), 3 deletions(-)
> >
> > diff --git a/libavformat/isom.h b/libavformat/isom.h
> > index 9038057..d684502 100644
> > --- a/libavformat/isom.h
> > +++ b/libavformat/isom.h
> > @@ -179,6 +179,7 @@ typedef struct MOVStreamContext {
> >      int32_t *display_matrix;
> >      uint32_t format;
> >
> > +    int has_sidx;  // If there is an sidx entry for this stream.
> >      struct {
> >          int use_subsamples;
> >          uint8_t* auxiliary_info;
>
> > diff --git a/libavformat/mov.c b/libavformat/mov.c
> > index 357d800..1b04b1a 100644
> > --- a/libavformat/mov.c
> > +++ b/libavformat/mov.c
> > @@ -4189,6 +4189,7 @@ static int mov_read_trun(MOVContext *c,
> AVIOContext *pb, MOVAtom atom)
> >
> >      frag->implicit_offset = offset;
> >
> > +    av_log(c, AV_LOG_DEBUG, "stindex: %d duration: %d end: %d\n",
> st->index, st->duration, sc->track_end);
>
> the types mismatch, also not sure this should be DEBUG or TRACE
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> When you are offended at any man's fault, turn to yourself and study your
> own failings. Then you will forget your anger. -- Epictetus
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>


More information about the ffmpeg-devel mailing list