[FFmpeg-devel] [PATCH] configure: make sure LTO does not optimize out the test functions

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Thu Oct 27 01:29:08 EEST 2016


On 26.10.2016 22:57, Carl Eugen Hoyos wrote:
> 2016-10-26 21:36 GMT+02:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
>> On 26.10.2016 10:52, Carl Eugen Hoyos wrote:
>>> 2016-10-26 1:16 GMT+02:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
>>>> I'm under the impression that __attribute__((used)) is not available
>>>> for all compilers,
>>
>>> Yes, but __attribute__((foo_bar)) does not break compilation here.
>>
>> Have you tested with MSVC?
> 
> No.

Then it's safer to assume it doesn't work.

>> On 26.10.2016 10:55, Carl Eugen Hoyos wrote:
>>> 2016-10-26 1:35 GMT+02:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
>>>
>>>> I forgot to include stdint.h. Fixed patch attached.
>>>
>>> Why don't you cast to (int)?
>>
>> Because gcc doesn't like it:
>> warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> 
> I don't see the problem with this warning but I guess you could use
> long, no?

As Hendrik said, intptr_t is the correct type here, so I see no reason not to use.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list