[FFmpeg-devel] [PATCH 02/10] crystalhd: Switch to new decode API and remove the insanity

[Philip Langdale]

On 2016-10-27 09:48, Nicolas George wrote:
> Le sextidi 6 brumaire, an CCXXV, Philip Langdale a écrit :
>> the library spams stdout (which sucks, but what can you do)
> 
> First step, look if there is a clean way of fixing it from the outside.
> Maybe by setting a logging callback? You probably already did that.
> 
> Second step, if there is no clean way of fixing it from the outside:
> make a bug report. You probably already did it too.

The code is abandoned by its creators, so yeah, these are futile.

> Third step, waiting for the bug to be fixed, and that maybe you did not
> think of because it is ugly:
> 
> 	saved_stdin = dup(1);
> 	dup2(2, 1);
> 	crystalhd_spamming_function();
> 	dup2(saved_stdin, 1);
> 	close(saved_stdin);

Horrifying.

--phil