[FFmpeg-devel] [PATCH] ffmpeg: copy the extradata from encoder to muxer

[Andreas Cadhalpun]

On 28.10.2016 01:33, James Almer wrote:
> On 10/27/2016 7:43 PM, Andreas Cadhalpun wrote:
>> To avoid confusion and for lack of a better name I called the variables in the encoder/muxer
>> contexts extra_side_data*.
> 
> extra_data* (with an underscore so it's different) is IMO better. It contains new codec
> extradata, as the AVPacketSideDataType enum states, and is simply transmitted from a
> library to the other as packet side data.

Sounds better, so I changed the names to that.

>> From 20ad7d6905ce2123fd8100b6fe6e092dbbdf3c06 Mon Sep 17 00:00:00 2001
>> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> Date: Thu, 27 Oct 2016 22:34:48 +0200
>> Subject: [PATCH] apng: use side data to pass extradata to muxer
>>
>> This fixes creating apng files, which is broken since commit
>> 5ef19590802f000299e418143fc2301e3f43affe.
>>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  libavcodec/pngenc.c   | 18 +++++++++++++++---
>>  libavformat/apngenc.c | 45 +++++++++++++++++++++++++++++++++++----------
>>  2 files changed, 50 insertions(+), 13 deletions(-)
> 
> Seems to work, so LGTM with or without the above suggestion.

Pushed. Thanks for the review.

Best regards,
Andreas