[FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

[Matt Oliver]

On 30 October 2016 at 20:21, Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Sun, Oct 30, 2016 at 5:13 AM, Matt Oliver <protogonoi at gmail.com> wrote:
> > On 30 October 2016 at 03:41, Stephen Hutchinson <qyot27 at gmail.com>
> wrote:
> >
> >> On 10/29/2016 11:22 AM, Michael Niedermayer wrote:
> >>
> >>> On Sat, Oct 29, 2016 at 06:35:19PM +1100, Matt Oliver wrote:
> >>>
> >>>>  configure              |    5 +----
> >>>>  libavformat/avisynth.c |   14 +++++---------
> >>>>  2 files changed, 6 insertions(+), 13 deletions(-)
> >>>> b1568f39504e5e14c924d27c8f11ba8f5816d68c
> 0003-avformat-avisynth.c-Use-n
> >>>> ew-safe-dlopen-code.patch
> >>>> From 633212cf1246b3fde61dd6515229e6a893005664 Mon Sep 17 00:00:00
> 2001
> >>>> From: Matt Oliver <protogonoi at gmail.com>
> >>>> Date: Sat, 29 Oct 2016 18:25:25 +1100
> >>>> Subject: [PATCH 3/4] avformat/avisynth.c: Use new safe dlopen code.
> >>>>
> >>>
> >>> breaks --enable-avisynth on linux/ubuntu
> >>>
> >>> --- config.h    2016-10-29 17:17:55.214014842 +0200
> >>> +++ delth/config.h      2016-10-29 17:15:41.906012034 +0200
> >>> @@ -1155,7 +1155,7 @@
> >>>  #define CONFIG_AST_DEMUXER 1
> >>>  #define CONFIG_AU_DEMUXER 1
> >>>  #define CONFIG_AVI_DEMUXER 1
> >>> -#define CONFIG_AVISYNTH_DEMUXER 1
> >>> +#define CONFIG_AVISYNTH_DEMUXER 0
> >>>  #define CONFIG_AVR_DEMUXER 1
> >>>  #define CONFIG_AVS_DEMUXER 1
> >>>  #define CONFIG_BETHSOFTVID_DEMUXER 1
> >>>
> >>> [...]
> >>>
> >>>
> >> Yeah, libdl needs to be linked to on non-Windows, and the
> >> check for it got removed with the rest of the 'enabled avisynth'
> >> case in configure. Just putting dlopen under avisynth_demuxer_deps
> doesn't
> >> seem to be sufficient for that to work.
> >
> >
> > Looks like I missed a line, my apologies. Updated version attached.
> >
>
> Looking at the configure changes - having a dependency on both dlopen
> and LoadLibrary sounds odd. Shouldn't it be either, not both?
>

Yes, unfortunately i was testing on mingw which has both. Fixed thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-avformat-avisynth.c-Use-new-safe-dlopen-code.patch
Type: application/octet-stream
Size: 3777 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161030/51c0a073/attachment.obj>