[FFmpeg-devel] [PATCH] interplayacm: validate number of channels

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Sun Oct 30 22:43:49 EET 2016


The number of channels is used as divisor in decode_frame, so it must
not be zero to avoid SIGFPE crashes.

Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
---
 libavcodec/interplayacm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libavcodec/interplayacm.c b/libavcodec/interplayacm.c
index f4a3446..c897e72 100644
--- a/libavcodec/interplayacm.c
+++ b/libavcodec/interplayacm.c
@@ -62,6 +62,11 @@ static av_cold int decode_init(AVCodecContext *avctx)
     if (avctx->extradata_size < 14)
         return AVERROR_INVALIDDATA;
 
+    if (avctx->channels <= 0) {
+        av_log(avctx, AV_LOG_ERROR, "Invalid number of channels: %d\n", avctx->channels);
+        return AVERROR_INVALIDDATA;
+    }
+
     s->level = AV_RL16(avctx->extradata + 12) & 0xf;
     s->rows  = AV_RL16(avctx->extradata + 12) >>  4;
     s->cols  = 1 << s->level;
-- 
2.10.1


More information about the ffmpeg-devel mailing list