[FFmpeg-devel] dash encoder. Correct generated manifest for MPEG-DASH MPD Validator and calculate current bandwidth for eath chunk. Now works correctly with dash.sj

Ligverd Haer ligverd at r46.ru
Tue Sep 6 13:56:57 EEST 2016


В письме от вторник, 6 сентября 2016 г. 12:26:49 MSK пользователь Carl Eugen

Attributes

profiles
width
height
sar
frameRate
audioSamplingRate
mimeType
segmentProfiles
codecs
maximumSAPPeriod
startWithSAP
maxPlayoutRate
codingDependency
scanType

Common attributes for AdaptationSet and Representation shall either be in one 
of the elements but not in both.

in particular, the attribute frameRate is duplicated in the node 
Representation

> > -        avio_printf(out, "\t\t<AdaptationSet contentType=\"video\"
> > segmentAlignment=\"true\" bitstreamSwitching=\"true\"");
> > -        if (c->max_frame_rate.num && !c->ambiguous_frame_rate)
> > -            avio_printf(out, " %s=\"%d/%d\"",
> > (av_cmp_q(c->min_frame_rate,
> > c->max_frame_rate) < 0) ? "maxFrameRate" : "frameRate",
> > c->max_frame_rate.num, c->max_frame_rate.den);
> > -        avio_printf(out, ">\n");
> > +        avio_printf(out, "\t\t<AdaptationSet contentType=\"video\"
> > segmentAlignment=\"true\" bitstreamSwitching=\"true\">\n");
> 
> This hunk is not ok because it is needlessly difficult to understand
> what you are changing:
> Leave the first ("AdaptionSet") and last ("\n") line unchanged -
> unless I misread the patch.



More information about the ffmpeg-devel mailing list