[FFmpeg-devel] adding RGBA and BGRA to nvenc.c

[Carl Eugen Hoyos]

Hi!

> Am 07.09.2016 um 11:36 schrieb Paul B Mahol <onemda at gmail.com>:
> 
>> On 9/7/16, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> Hi!
>> 
>> 2016-09-07 2:23 GMT+02:00 Sven C. Dack <sven.c.dack at sky.com>:
>>>> On 07/09/16 01:08, Sven C. Dack wrote:
>>>> 
>>>>> On 07/09/16 00:43, Carl Eugen Hoyos wrote:
>>>>> 
>>>>> Should be AV_PIX_FMT_RGB0...
>> 
>> As pointed out by Timo, this should be AV_PIX_FMT_0BGR32...
>> 
>>>>> ... and AV_PIX_FMT_BGR0
>> 
>> ... and this AV_PIX_FMT_0RGB32: It makes no difference on
>> little-endian, but matches the documentation.
>> Sorry for not realizing this yesterday!
>> 
>>> +    AV_PIX_FMT_RGB0,
>>> +    AV_PIX_FMT_BGR0,
>> 
>>> +    AV_PIX_FMT_RGBA,
>>> +    AV_PIX_FMT_BGRA,
>> 
>> In any case, please remove AV_PIX_FMT_RGBA and AV_PIX_FMT_BGRA,
>> the encoder cannot deal with transparency.
> 
> And how do you know that?

If the encoder would deal with transparency (which it does not) RGB0 would be wrong but it seems everybody agrees it is correct.

Carl Eugen