[FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

[Michael Niedermayer]

On Wed, Sep 07, 2016 at 02:27:07PM +0200, Michael Niedermayer wrote:
> On Wed, Sep 07, 2016 at 08:03:20AM -0400, Ronald S. Bultje wrote:
> > Hi,
> > 
> > On Wed, Sep 7, 2016 at 7:51 AM, Michael Niedermayer <michael at niedermayer.cc>
> > wrote:
> > 
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > > ---
> > >  doc/developer.texi | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/doc/developer.texi b/doc/developer.texi
> > > index 4d3a7ae..51e3da7 100644
> > > --- a/doc/developer.texi
> > > +++ b/doc/developer.texi
> > > @@ -641,6 +641,12 @@ are notoriously left unchecked, which is a serious
> > > problem.
> > >  @item
> > >  Test your code with valgrind and or Address Sanitizer to ensure it's free
> > >  of leaks, out of array accesses, etc.
> > > +
> > > + at item
> > > +Check that your submitted patch shows up on @url{
> > > https://patchwork.ffmpeg.org}.
> > > +Also make sure its status is updated, you can create an account and
> > > update it.
> > > +If your patch is incorrectly or not listed in patchwork then it might be
> > > +missed by developers using patchwork to find patches needing review or
> > > pushing.
> > >  @end enumerate
> > 
> > 
> > I don't think we should require developers to use (or check, or update, or
> > create-an-account-on) patchwork. Wasn't the whole point of patchwork that
> > you can use it if you care, and you can ignore it if you don't care?
> 
> yes one can ignore it but its alot more usefull if people keep in
> mind that theres patchwork.
> 
> For example, if you reply with LGTM or Acked-by: or Reviewed-by:
> or Tested-by:
> patchwork will pick that up, OTOH if you write "that works well,
> i tested it" patchwork will not pick that up, nor will it "dude that
> looks fine, please push it" nor does it "I dont like that change"
> 
> the result of that is that if everyone ignores patchwork it will
> contain most submited patches (some odd non standard attachmets are
> missed)

also due to this, people using patchwork to find patches that need a
review will miss patches that patchwork didnt pick up. So its useful
if such not picked up patches are 0
Iam one of the people using patchwork to keep track of patches still
needing review or application if i dont review them immedeatly.
Using my MUA for this has become too painfull and
inefficient and noone else knows whats marked as unread (needing review)
in my MUA, anyone knows what still needs a review in patchwork as its
vissible to the world

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160907/3ca1b661/attachment.sig>