[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

[Aman Gupta]

On Thu, Sep 8, 2016 at 9:18 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> 2016-09-08 15:48 GMT+02:00 Aman Gupta <themastermind1 at gmail.com>:
> > On Thursday, September 8, 2016, Carl Eugen Hoyos <ceffmpeg at gmail.com>
> wrote:
> >
> >> 2016-09-08 10:19 GMT+02:00 Aman Gupta <ffmpeg at tmm1.net <javascript:;>>:
> >>
> >> > +    { "a53cc", "Use A53 Closed Captions (if available)",
> >> OFFSET(a53_cc), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, VE },
> >>
> >> Why is this disabled by default?
> >
> > I copied this from the libx264 and qsv encoders, which also disable by
> > default. Not sure why.
>
> If you believe it should be enabled by default, please send a patch that
> enables the function by default.
> (If there is no issue, the others can be fixed.)
>

I don't have a good enough understanding of the possible consequences to
feel comfortable enabling it by default yet.


>
> Thank you, Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>