[FFmpeg-devel] [PATCH 2/2] avformat/flvenc: add no_sequence_end flags for flvflags

[Michael Niedermayer]

On Tue, Sep 13, 2016 at 10:10:40PM +0800, Steven Liu wrote:
[...]
>  flvenc.c |   18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 42fedcf3213941fce3f2c0a6ea879002e178fa75  0002-avformat-flvenc-add-no_sequence_end-flags-for-flvfla.patch
> From c0297aa790e72b14bd01fcb5862e66636bc43400 Mon Sep 17 00:00:00 2001
> From: Steven Liu <lingjiujianke at gmail.com>
> Date: Tue, 13 Sep 2016 22:03:59 +0800
> Subject: [PATCH 2/2] avformat/flvenc: add no_sequence_end flags for flvflags
> 
> when split flv file by flv format at first, and cat flvs file
> into one flv file, the flv sequence end is be used,
> then the whole flv have many flv sequence end TAG.
> this flags can give user an option to ignore write sequence end TAG
> 
> Signed-off-by: Steven Liu <lingjiujianke at gmail.com>
> ---
>  libavformat/flvenc.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)

missing update to docs/


> 
> diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
> index a3623f8..9e95b8d 100644
> --- a/libavformat/flvenc.c
> +++ b/libavformat/flvenc.c
> @@ -63,6 +63,7 @@ static const AVCodecTag flv_audio_codec_ids[] = {
>  
>  typedef enum {
>      FLV_AAC_SEQ_HEADER_DETECT = (1 << 0),
> +    FLV_NO_SEQUENCE_END = (1 << 1),
>  } FLVFlags;
>  
>  typedef struct FLVContext {
> @@ -527,13 +528,15 @@ static int flv_write_trailer(AVFormatContext *s)
>      FLVContext *flv = s->priv_data;
>      int i;
>  
> -    /* Add EOS tag */
> -    for (i = 0; i < s->nb_streams; i++) {
> -        AVCodecParameters *par = s->streams[i]->codecpar;
> -        FLVStreamContext *sc = s->streams[i]->priv_data;
> -        if (par->codec_type == AVMEDIA_TYPE_VIDEO &&
> -                (par->codec_id == AV_CODEC_ID_H264 || par->codec_id == AV_CODEC_ID_MPEG4))
> -            put_avc_eos_tag(pb, sc->last_ts);
> +    if (flv->flags & FLV_NO_SEQUENCE_END == 0) {

please add a (), that makes greping for order or precedenc bugs much
easier

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160914/dfdbb1c4/attachment.sig>