[FFmpeg-devel] [PATCH 1/4] lavd: Add SDL2 output device

[James Almer]

On 9/14/2016 7:27 PM, Josh de Kock wrote:
> Acked-by: Michael Niedermayer
> Signed-off-by: Josh de Kock <josh at itanimul.li>
> ---
>  configure                |  28 +++-
>  libavdevice/Makefile     |   1 +
>  libavdevice/alldevices.c |   1 +
>  libavdevice/sdl2.c       | 377 +++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 406 insertions(+), 1 deletion(-)
>  create mode 100644 libavdevice/sdl2.c
> 

Missing changelog entry about SDL2 outdev.

Also one for the ffplay SDL2 port in patch 3.

> diff --git a/configure b/configure
> index b11ca7f..6ef2410 100755
> --- a/configure
> +++ b/configure
> @@ -292,6 +292,7 @@ External library support:
>    --disable-schannel       disable SChannel SSP, needed for TLS support on
>                             Windows if openssl and gnutls are not used [autodetect]
>    --disable-sdl            disable sdl [autodetect]
> +  --disable-sdl2           disable sdl2 [autodetect]
>    --disable-securetransport disable Secure Transport, needed for TLS support
>                             on OSX if openssl and gnutls are not used [autodetect]
>    --enable-x11grab         enable X11 grabbing (legacy) [no]
> @@ -1548,6 +1549,7 @@ EXTERNAL_LIBRARY_LIST="
>      openssl
>      schannel
>      sdl
> +    sdl2
>      securetransport
>      videotoolbox
>      x11grab
> @@ -2022,6 +2024,7 @@ HAVE_LIST="
>      perl
>      pod2man
>      sdl
> +    sdl2
>      section_data_rel_ro
>      texi2html
>      threads
> @@ -2945,6 +2948,7 @@ pulse_outdev_deps="libpulse"
>  qtkit_indev_extralibs="-framework QTKit -framework Foundation -framework QuartzCore"
>  qtkit_indev_select="qtkit"
>  sdl_outdev_deps="sdl"
> +sdl2_outdev_deps="sdl2"
>  sndio_indev_deps="sndio_h"
>  sndio_outdev_deps="sndio_h"
>  v4l_indev_deps="linux_videodev_h"
> @@ -5850,7 +5854,7 @@ if enabled gcrypt; then
>      fi
>  fi
>  
> -if ! disabled sdl; then
> +if ! disabled sdl && ! enabled sdl2; then

SDL2 should be the default. Especially if ffplay's SDL1 version
is going to be marked as deprecated and probably also removed
next year.