[FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

[Steven Liu]

2016-09-14 6:51 GMT+08:00 Steven Liu <lingjiujianke at gmail.com>:

>
>
> 2016-09-14 2:53 GMT+08:00 Moritz Barsnick <barsnick at gmx.net>:
>
>> On Tue, Sep 13, 2016 at 11:25:39 +0800, Steven Liu wrote:
>> > +    int byterange_mode = hls->flags & (HLS_SINGLE_FILE) ||
>> hls->max_seg_size > 0;
>>                                          ^               ^
>> Why the bracket?
>>
>> > +                av_log(oc, AV_LOG_ERROR, "Invalid segment filename
>> template '%s' you can try use -use_localtime 1 with it\n", c->basename);
>> Rather:
>>                    av_log(oc, AV_LOG_ERROR, "Invalid segment filename
>> template '%s', you can try to use -use_localtime 1 with it\n", c->basename);
>>
>> > +    {"hls_segment_size", "set maximum size per segment file, (Byte)",
>> OFFSET(max_seg_size),    AV_OPT_TYPE_INT,    {.i64 = 0},     0, INT_MAX, E},
>>        {"hls_segment_size", "set maximum size per segment file (in
>> bytes)",  OFFSET(max_seg_size),    AV_OPT_TYPE_INT,    {.i64 = 0},     0,
>> INT_MAX, E},
>>
>> This isn't a flag, right? Perhaps you shouldn't be putting the option
>> between the flags' lines (but probably still as the final option).
>>
> I shall update patch :-)
>
>>
>> The value of 0 seems to have a special meaning. Is this documented
>>
> I cannot understand "The value of 0 seems to have a special meaning" ,
> it will not set value when unuse hls_segment_size, so give it value of 0.
> is that a problem?
>
>> anywhere? In other words: You should also update doc/muxers.texi. (I
>> can help with the grammar of the wording.)
>>
> patch will come soon :-D
>
>>
>>
patch update
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avformat-hlsenc-refine-EXT-X-BYTERANGE-support-for-s.patch
Type: application/octet-stream
Size: 7513 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160915/aa81f9bb/attachment.obj>