[FFmpeg-devel] [PATCH]lavf/riffenc: Always write unexpected channel_mask

[Carl Eugen Hoyos]

2016-09-27 9:38 GMT+02:00 Tobias Rapp <t.rapp at noa-archive.com>:
> On 27.09.2016 09:02, Carl Eugen Hoyos wrote:
>>
>> 2016-09-27 8:49 GMT+02:00 Tobias Rapp <t.rapp at noa-archive.com>:
>>>
>>> On 26.09.2016 12:39, Carl Eugen Hoyos wrote:
>>
>>>> Attached patch allows to write arbitrary (mono) channel_masks
>>>> even for 16bit 48kHz pcm audio.
>>>
>>> As far as I understand this patch is in response to
>>> https://ffmpeg.org/pipermail/ffmpeg-user/2016-September/033757.html
>>> but in my opinion it doesn't match Robert's use-case.
>>
>> Where do I claim this?
>
> It was how I interpreted the "just sent a patch" in
> https://ffmpeg.org/pipermail/ffmpeg-user/2016-September/033756.html .

"I just sent a patch after trying to interpret your report that
was missing command line and console output."

I only understood later what Robert needs and I believe it does
fix a (not extremely unusual) use-case.

>> Do you believe the patch is wrong or does something
>> unexpected?
>
> The patch looks fine, although I haven't actually tested it.
>
>>> Instead the "-channel_layout 0" input option should be fixed
>>
>> Please do send a patch!
>
> Some time ago I tried to work on it but it turned out to be quite difficult

> especially when adding some audio filters (amerge? pan?) to the pipeline.

This issue may have been fixed, some filters do not require a channel
layout anymore. In any case, fixing the issue for the no-filter case would
be a step forward imo.

Carl Eugen