[FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

[Michael Niedermayer]

On Thu, Sep 29, 2016 at 09:54:42PM +0100, Josh de Kock wrote:
> There is really no need for two aac wrappers, we already have
> libfdk-aac which is better. Not to mention that faac doesn't
> even support HEv1, or HEv2. It's also under a license which is
> unusable for distribution, so it would only be useful to people
> who will compile their own ffmpeg, only use it themselves (which
> at that point should just use fdk-aac).
> 
> Signed-off-by: Josh de Kock <josh at itanimul.li>
> ---
>  Changelog              |   1 +
>  LICENSE.md             |   2 -
>  configure              |   6 --
>  doc/encoders.texi      | 105 ---------------------
>  doc/ffserver.conf      |   2 +-
>  doc/general.texi       |   2 +-
>  doc/muxers.texi        |   4 +-
>  doc/platform.texi      |   2 +-
>  libavcodec/Makefile    |   1 -
>  libavcodec/allcodecs.c |   1 -
>  libavcodec/libfaac.c   | 248 -------------------------------------------------
>  11 files changed, 6 insertions(+), 368 deletions(-)
>  delete mode 100644 libavcodec/libfaac.c

dont remember if it was specific to libfaac but some issues in the
mov edit list patches about initial padding and trailing padding
where found using libfaac as encoder.
if libfaac support is droped, muxers wont be tested against it anymore
most likely. It could be done with command line faac and remuxing but
that special case makes it so unwieldy that i doubt anyone will do it

also quite some testcases in trac tickets used libfaac as it was
default at the time,
regression testing future changes against these tickets may be
unreliable without libfaac

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160930/48b8f7f6/attachment.sig>