[FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

[Michael Niedermayer]

On Fri, Sep 30, 2016 at 10:33:04AM +0200, Timo Rothenpieler wrote:
> > dont remember if it was specific to libfaac but some issues in the
> > mov edit list patches about initial padding and trailing padding
> > where found using libfaac as encoder.
> > if libfaac support is droped, muxers wont be tested against it anymore
> > most likely. It could be done with command line faac and remuxing but
> > that special case makes it so unwieldy that i doubt anyone will do it
> > 
> > also quite some testcases in trac tickets used libfaac as it was
> > default at the time,
> > regression testing future changes against these tickets may be
> > unreliable without libfaac
> 
> Isn't it possible to just generate raw aac, or some other low level
> container format, with faac, and store those as fate samples?

It is probably possible for some cases and it would be a good idea
either way, but iam not sure theres a volunteer to do this.

btw, I think the most suitable and flexible format for this is the
ffprobe one requiring the ffprobe demuxer patch
It would allow all kinds of transformations to be done with a minimum
of work to create more minimal test cases.


> Or does that not show the same issue, so that the tests can stay even
> without libfaac itself?

Theres no way i can really say how hundreads of tickets behave if
they are turned from encoding into stream copy. My guess is that for
many that would work for some it would probably not work

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160930/34a4a774/attachment.sig>