[FFmpeg-devel] [PATCH] lavc: remove libfaac wrapper

[Michael Niedermayer]

On Fri, Sep 30, 2016 at 08:00:53PM +0100, Rostislav Pehlivanov wrote:
> On 30 September 2016 at 18:12, Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > On Fri, Sep 30, 2016 at 10:33:04AM +0200, Timo Rothenpieler wrote:
> > > > dont remember if it was specific to libfaac but some issues in the
> > > > mov edit list patches about initial padding and trailing padding
> > > > where found using libfaac as encoder.
> > > > if libfaac support is droped, muxers wont be tested against it anymore
> > > > most likely. It could be done with command line faac and remuxing but
> > > > that special case makes it so unwieldy that i doubt anyone will do it
> > > >
> > > > also quite some testcases in trac tickets used libfaac as it was
> > > > default at the time,
> > > > regression testing future changes against these tickets may be
> > > > unreliable without libfaac
> > >
> > > Isn't it possible to just generate raw aac, or some other low level
> > > container format, with faac, and store those as fate samples?
> >
> > It is probably possible for some cases and it would be a good idea
> > either way, but iam not sure theres a volunteer to do this.
> >
> >
> I'll do it, just post links to the tickets.

I dont have a list of tickets that used libfaac and iam not sure how
to search for them

you can find some by searching for
"-> libfaac"
"-> aac (libfaac)"
This will only work when that part of the output was quoted in the
ticket, like in tickets with full uncut output. Iam not sure this
covers all ffmpeg versions either

the more tickets can be turned into fate tests the better, libfaac or
not.

Also i do not object to libfaacs removial i just was trying to point
out the disadvantages i saw if its done.
As you surely noiced i rarely am a supporter of removing features ...

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160930/fa586b9d/attachment.sig>