[FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

[Steven Liu]

2017-04-01 16:01 GMT+08:00 Nicolas George <george at nsup.org>:

> Le primidi 11 germinal, an CCXXV, Steven Liu a écrit :
> > I think just similar, not duplicating, and the simple functionality use
> > BPrint maybe too complex.
>
> Well, I will say it unambiguously:
>
> Parts of this patch DO duplicate logic that we already have, and your
> statement about BPrint being too complex is simply completely wrong.
>
Ok, Can you guide me to improve it please?

>
> Therefore, it was not acceptable as is and should not have been pushed.
>
> Pushing while leaving only half a day to answer this was UNACCEPTABLE.
> Do not ever do it again please.
>
> Now, I will not insist on reverting, but I will demand that you make a
> priority of simplifying this code.
>
> Regards,
>
> --
>   Nicolas George
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>