[FFmpeg-devel] [PATCH 2/2] Add http cookie tests cases to fate

[Micah Galizia]

On 2017-03-31 06:10 AM, Michael Niedermayer wrote:
> On Thu, Mar 30, 2017 at 09:33:48PM -0400, Micah Galizia wrote:
>> Signed-off-by: Micah Galizia <micahgalizia at gmail.com>
>> ---
>>   libavformat/Makefile       |   1 +
>>   libavformat/tests/http.c   | 182 +++++++++++++++++++++++++++++++++++++++++++++
>>   tests/fate/libavformat.mak |   5 ++
>>   tests/ref/fate/http        |  30 ++++++++
>>   4 files changed, 218 insertions(+)
>>   create mode 100644 libavformat/tests/http.c
>>   create mode 100644 tests/ref/fate/http
> the test segfaults
>
> 'good=not_expired; domain=.test.com; path=/; expires=Fri, 12 Mar 2117 02:53:03 GMT; HttpOnly'->'expires'|'Fri, 12 Mar 2117 02:53:03 GMT'
> 'good=great'->'good'|'great'
> 0) 'first="good"; Domain=.test.com; Path=/
> second=great; domain=.test.com; path=/; HttpOnly'=>'first="good"; second=great'
>
> Unable to parse 'expired="really_old"; Domain=.test.com; Expires=Thu, 01 Jan 1970 00:00:10 GMT; Path=/'
> 1) 'expired="really_old"; Domain=.test.com; Expires=Thu, 01 Jan 1970 00:00:10 GMT; Path=/
> good=not_expired; domain=.test.com; path=/; expires=Fri, 12 Mar 2117 02:53:03 GMT; HttpOnly'=>'good=not_expired'
>
> Unable to parse 'expired="really_old"; Domain=.test.com; Expires=Thu, 01-Jan-1970 00:00:10 GMT; Path=/'
> 2) 'expired="really_old"; Domain=.test.com; Expires=Thu, 01-Jan-1970 00:00:10 GMT; Path=/
> neulion=not_expired; domain=.test.com; path=/; expires=Fri, 12-Mar-2117 02:53:03 GMT; HttpOnly'=>'neulion=not_expired'
>
> 3) 'no_day=still_ok; domain=.test.com; path=/; expires=12-Mar-2117 02:53:03 GMT; HttpOnly'=>'no_day=still_ok'
>
> 4) 'unparsable_date=allow_cookie; domain=.test.com; path=/; expires=12-Mur-2117 02:53:03 GMT; HttpOnly'=>'unparsable_date=allow_cookie'
>
> 5) 'different_domain=exclude; domain=.nottest.com; path=/; expires=12-Mar-2117 02:53:03 GMT; HttpOnly'=>'(null)'
>
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x00007ffff5851166 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
> (gdb) bt
> #0  0x00007ffff5851166 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
> #1  0x000000000041197c in test_get_cookies () at libavformat/tests/http.c:97
> #2  0x000000000041056b in main () at libavformat/tests/http.c:173
>
> [...]
Thanks,

I'm trying to reproduce your results here without success -- I can't get 
it to crash on my system. I'm on the same architecture as you are 
(x86_64) too... based on the backtrace I'm guessing maybe strcmp doesn't 
like s2 being null, even though it works on my system -- I'll add an 
explicit case for when they're both null so we're not comparing two null 
strings and resubmit.

Thanks for running it/sorry for the crash. I'll try to send a fix today 
some time.