[FFmpeg-devel] [PATCH] mjpegenc: enable optimal huffman coding by default

[Michael Niedermayer]

On Mon, Apr 03, 2017 at 10:31:27PM +0100, Rostislav Pehlivanov wrote:
> As it gives excellent encoding gains at an insignificant speed increase
> and passes fate without problems, it should now be safe to enable by
> default.

Still breaks slice threading

both
Assertion n <= 31 && value < (1U << n) failed at libavcodec/put_bits.h:157

and
Assertion (header_bits & 7) == 0 failed at libavcodec/mjpegenc_common.c:541

occur with
./ffmpeg -y -i ~/fatesamples/fate/fate-suite/lena.pnm  -vf scale -strict -1  -threads 2 -thread_type slice test.jpg

randomly

also ive seen it not trigger an assert on repeating the command

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170404/11a37953/attachment.sig>