[FFmpeg-devel] [PATCH] avfilter/vf_dctdnoiz: add GBRP support

[Clément Bœsch]

On Sun, Apr 09, 2017 at 05:40:13PM +0200, Paul B Mahol wrote:
[...]
> +static av_always_inline void color_decorrelation_gbrp(float **dst, int dst_linesize,
> +                                                      const uint8_t **src, int src_linesize,
> +                                                      int w, int h)
> +{
> +    int x, y;
> +    float *dstp_r = dst[0];
> +    float *dstp_g = dst[1];
> +    float *dstp_b = dst[2];
> +    const uint8_t *srcp_r = src[2];
> +    const uint8_t *srcp_g = src[0];
> +    const uint8_t *srcp_b = src[1];
> +
> +    for (y = 0; y < h; y++) {
> +        for (x = 0; x < w; x++) {

> +            dstp_r[x] = srcp_r[x] * DCT3X3_0_0 + srcp_g[x] * DCT3X3_0_1 + srcp_b[x] * DCT3X3_0_2;
> +            dstp_g[x] = srcp_g[x] * DCT3X3_1_0 +                          srcp_b[x] * DCT3X3_1_2;
> +            dstp_b[x] = srcp_b[x] * DCT3X3_2_0 + srcp_g[x] * DCT3X3_2_1 + srcp_b[x] * DCT3X3_2_2;
                                ^
              i think this column is supposed to be reds
> +        }
> +        srcp_r += src_linesize;
> +        srcp_g += src_linesize;
> +        srcp_b += src_linesize;
> +        dstp_r += dst_linesize;
> +        dstp_g += dst_linesize;
> +        dstp_b += dst_linesize;
> +    }
> +}

Rest LGTM

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170409/49131864/attachment.sig>