[FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

Carl Eugen Hoyos ceffmpeg at gmail.com
Fri Apr 14 15:34:23 EEST 2017


2017-04-14 14:30 GMT+02:00 Carl Eugen Hoyos <ceffmpeg at gmail.com>:
> 2017-04-14 13:11 GMT+02:00 Rostislav Pehlivanov <atomnuker at gmail.com>:

>> Point is, I have used only code from libavcodec/opus_pvq.c from
>> the FFmpeg project. I don't have to do anything as all credit has
>> been given where due.
>
> I don't understand:
> The file opus_pvq.c contains copyright notices from Andrew
> D'Addesio and Mozilla. If you have used code from opus_pvq.c,
> shouldn't you add these copyright notices to the opus encoder?

Or did you mean that you only used code that was already
present in libavcodec/opus_pvq.c without copying anything
to the new files you wrote (what "using" implied to me)?

Carl Eugen


More information about the ffmpeg-devel mailing list