[FFmpeg-devel] [PATCH] avdevice/decklink: Removed pthread dependency

[James Almer]

On 4/15/2017 7:41 AM, Marton Balint wrote:
> 
> On Thu, 13 Apr 2017, Aaron Levinson wrote:
> 
>> On 4/13/2017 3:40 PM, Marton Balint wrote:
>>>
>>> On Thu, 13 Apr 2017, Aaron Levinson wrote:
>>>
>>>> On 4/13/2017 2:12 AM, Hendrik Leppkes wrote:
>>>>> On Thu, Apr 13, 2017 at 10:36 AM, Aaron Levinson <alevinsn at aracnet.com> 
>>>> wrote:
>>>>> Give it some time for the other changes to be reviewed by the people
>>>>> that actually know decklink itself, you can include that in any new
>>>>> versions of the patch then, no need to send one for that right now.
>>>>>
>>>>> - Hendrik
>>>>
>>>> Actually, the coding changes made to the decklink source files in this
>>>> patch have pretty much nothing to do with decklink itself, and anyone
>>>> with familiarity with semaphores and pthread could review those changes.
>>>>  In fact, all I really did was use already existing approaches for
>>>> replacing a semaphore with the combination of a condition variable,
>>>> mutex, and counter, and there are plenty of examples of how to do this
>>>> on the Web.
>>>>
>>>
>>> Yeah, the changes look fine, please send an updated patch, I will apply
>>> it after some final testing.
>>>
>>> Thanks,
>>> Marton
>>
>> Here's a new version of the patch with the pthreads dependency replaced with threads.
>>
> 
> Thanks, applied.

Wouldn't it be simpler to add posix semaphore emulation to w32threads
and os2threads?
The former should be trivial, and probably even without the need to
use mutexes or conditional variables given there's CreateSemaphore
and ReleaseSemaphore for this purpose. Not sure about the latter.