[FFmpeg-devel] [PATCH] This patch I add the check for venc->window_sequence[0], and set venc->log2_blocksize[0]=8 when venc->window_sequence[0] is the EIGHT_SHORT_SEQUENCE.

[Michael Niedermayer]

On Sun, Apr 23, 2017 at 03:27:30AM -0400, Ruyi Ji wrote:
> Signed-off-by: Ruyi Ji <jiruyi1 at gmail.com>
> ---
>  libavcodec/psymodel.c        |   1 +
>  libavcodec/vorbis_enc_data.h | 111 +++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/vorbisenc.c       |  68 +++++++++++++++++++++++++-
>  3 files changed, 179 insertions(+), 1 deletion(-)

Breaks
make fate-vorbis-encode

==25091== Invalid read of size 4
==25091==    at 0x103AA8A: psy_lame_window (in ffmpeg/ffmpeg_g)
==25091==    by 0xBA5757: vorbis_encode_frame (in ffmpeg/ffmpeg_g)
==25091==    by 0x81282F: avcodec_encode_audio2 (in ffmpeg/ffmpeg_g)
==25091==    by 0x813234: do_encode (in ffmpeg/ffmpeg_g)
==25091==    by 0x813357: avcodec_send_frame (in ffmpeg/ffmpeg_g)
==25091==    by 0x4BDC1B: reap_filters (in ffmpeg/ffmpeg_g)
==25091==    by 0x4C3DEA: transcode (in ffmpeg/ffmpeg_g)
==25091==    by 0x4A4227: main (in ffmpeg/ffmpeg_g)
==25091==  Address 0x19bb1618 is 8 bytes after a block of size 496 free'd
==25091==    at 0x4C2B5D9: free (vg_replace_malloc.c:446)
==25091==    by 0x5DAA51: filter_frame (in ffmpeg/ffmpeg_g)
==25091==    by 0x4E3CD6: ff_filter_activate (in ffmpeg/ffmpeg_g)
==25091==    by 0x4E7FC7: av_buffersrc_add_frame_internal (in ffmpeg/ffmpeg_g)
==25091==    by 0x4E833D: av_buffersrc_add_frame_flags (in ffmpeg/ffmpeg_g)
==25091==    by 0x4BE394: send_frame_to_filters (in ffmpeg/ffmpeg_g)
==25091==    by 0x4BFD29: process_input_packet (in ffmpeg/ffmpeg_g)
==25091==    by 0x4C1820: process_input (in ffmpeg/ffmpeg_g)
==25091==    by 0x4C3DD0: transcode (in ffmpeg/ffmpeg_g)
==25091==    by 0x4A4227: main (in ffmpeg/ffmpeg_g)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170423/57eb5a52/attachment.sig>