[FFmpeg-devel] [RFC] Reviewing merges

[Carl Eugen Hoyos]

2017-04-24 13:39 GMT+02:00 Ronald S. Bultje <rsbultje at gmail.com>:
> Hi,
>
> On Mon, Apr 24, 2017 at 5:57 AM, wm4 <nfxjfg at googlemail.com> wrote:
>
>> On Mon, 24 Apr 2017 10:46:38 +0200
>> Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> > 2017-04-24 5:50 GMT+02:00 Aaron Levinson <alevinsn at aracnet.com>:
>> > > On 4/23/2017 7:07 PM, Michael Niedermayer wrote:
>> > >>
>> > >> Should changes ported from libav (what we call merges) be
>> > >> reviewed before being pushed?
>> > >
>> > > I've asked about this on IRC (#ffmpeg-devel).  The overall
>> > > consensus there, at least at the time I asked it, is there is an
>> > > expectation that such changes have already been properly
>> > > reviewed for libav, so they are likely to be okay for ffmpeg,
>> > > and while some issues have crept into ffmpeg as a result
>> > > of these merges, the merge process has gone smoothly
>> > > overall.
>> >
>> > This does not sound correct to me.
>>
>> Are you joking?

No, definitely not.

> What he meant was: it depends who does the merges, or rather,
> what political faction (s)he is part of.
>
> Tsk, tsk.

(Apart from the Coc, I don't remember if you agreed or not:)

Please try to comment on technical issues (or at least stay with
the facts), the insults are less useful for this conversation.

Carl Eugen