[FFmpeg-devel] [PATCH v2] avformat/dash: move reused API to common file and header file

[James Almer]

On 8/31/2017 6:00 AM, Steven Liu wrote:
> diff --git a/libavformat/dash.h b/libavformat/dash.h
> new file mode 100644
> index 0000000000..941f7fded1
> --- /dev/null
> +++ b/libavformat/dash.h
> @@ -0,0 +1,39 @@
> +/*
> + * MPEG-DASH ISO BMFF segmenter
> + * Copyright (c) 2014 Martin Storsjo
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#ifndef AVFORMAT_DASHCOMM_H

You also need to adapt this guard to the new name.

> +#define AVFORMAT_DASHCOMM_H
> +#include "avformat.h"
> +
> +// See ISO/IEC 23009-1:2014 5.3.9.4.4
> +typedef enum {
> +    DASH_TMPL_ID_UNDEFINED = -1,
> +    DASH_TMPL_ID_ESCAPE,
> +    DASH_TMPL_ID_REP_ID,
> +    DASH_TMPL_ID_NUMBER,
> +    DASH_TMPL_ID_BANDWIDTH,
> +    DASH_TMPL_ID_TIME,
> +} DASHTmplId;
> +
> +
> +void dash_fill_tmpl_params(char *dst, size_t buffer_size, const char *template, int rep_id, int number, int bit_rate, int64_t time);

Internal shared API uses the ff_ prefix.

> +
> +#endif /* AVFORMAT_DASHCOMM_H */