[FFmpeg-devel] [PATCH] avfilter/vf_threshold: add x86 SIMD

[James Almer]

On 12/1/2017 3:41 PM, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavfilter/threshold.h             | 51 +++++++++++++++++++++++++++
>  libavfilter/vf_threshold.c          | 28 ++++-----------
>  libavfilter/x86/Makefile            |  2 ++
>  libavfilter/x86/vf_threshold.asm    | 69 +++++++++++++++++++++++++++++++++++++
>  libavfilter/x86/vf_threshold_init.c | 41 ++++++++++++++++++++++
>  5 files changed, 169 insertions(+), 22 deletions(-)
>  create mode 100644 libavfilter/threshold.h
>  create mode 100644 libavfilter/x86/vf_threshold.asm
>  create mode 100644 libavfilter/x86/vf_threshold_init.c

[..]

> diff --git a/libavfilter/x86/vf_threshold_init.c b/libavfilter/x86/vf_threshold_init.c
> new file mode 100644
> index 0000000000..e2bbae11d5
> --- /dev/null
> +++ b/libavfilter/x86/vf_threshold_init.c
> @@ -0,0 +1,41 @@
> +/*
> + * Copyright (c) 2015 Paul B Mahol
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#include "libavutil/attributes.h"
> +#include "libavutil/cpu.h"
> +#include "libavutil/x86/cpu.h"
> +#include "libavfilter/threshold.h"
> +
> +void ff_threshold8_sse4(const uint8_t *in, const uint8_t *threshold,
> +                        const uint8_t *min, const uint8_t *max,
> +                        uint8_t *out,
> +                        ptrdiff_t ilinesize, ptrdiff_t tlinesize,
> +                        ptrdiff_t flinesize, ptrdiff_t slinesize,
> +                        ptrdiff_t olinesize,
> +                        int w, int h);
> +
> +av_cold void ff_threshold_init_x86(ThresholdContext *s)
> +{
> +    int cpu_flags = av_get_cpu_flags();
> +
> +    if (ARCH_X86_64 && EXTERNAL_SSE4(cpu_flags) && s->depth == 8) {
> +        s->threshold = ff_threshold8_sse4;
> +    }
> +}
> 

Can you add a checkasm test for this function, or at least a normal test
for the filter that covers it?