[FFmpeg-devel] [PATCH] arm/hevc_idct: fix compilation on Android

[Jan Ekström]

On Sat, Dec 9, 2017 at 2:52 PM, Jan Ekström <jeebjp at gmail.com> wrote:
> On Sat, Dec 9, 2017 at 12:14 AM, James Almer <jamrial at gmail.com> wrote:
>> Compilation error "out of range" fixed for armeabi-v7a. Compilation failed
>> trying to build libvlc.aar for ARM7 android on ubuntu 16.04 host. Error
>> messages is "Offset out of range". The reason of the error is assembler LDR
>> directives in function "ff_hevc_transform_luma_4x4_neon_8" need local storage
>> in range <1k, but no such storage provided.
>>
>> Based on a patch by Ihor Bobalo <bob at eleks.com>
>>
>> Suggested-by: wbs
>> Signed-off-by: James Almer <jamrial at gmail.com>
>>
>
> Can confirm that this fixes compilation, clang+gas-preprocessor works. Thanks.
>
> Jan

Aditionally tested with armv7 GCC 4.9 as well, so nothing seems to be
broken on that side, either. This is not surprising, as this only
moves a function and a macro - as well as adds a .ltorg which causes
the literal pool to be dumped. This helps as the offsets are getting
too large otherwise for the SIMD used in the following function.

Given the limited change in this, I'd say LGTM and will push tonight
unless someone objects.

Jan