[FFmpeg-devel] [PATCH] avutil/internal: Document ugly looking windows specific file related function renaming

[wm4]

On Wed,  1 Feb 2017 14:35:50 +0100
Michael Niedermayer <michael at niedermayer.cc> wrote:

> Found-by: ubitux
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavutil/internal.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libavutil/internal.h b/libavutil/internal.h
> index a19975d474..e97034887b 100644
> --- a/libavutil/internal.h
> +++ b/libavutil/internal.h
> @@ -243,8 +243,12 @@ void avpriv_request_sample(void *avc,
>  #pragma comment(linker, "/include:" EXTERN_PREFIX "avpriv_snprintf")
>  #endif
>  
> +// Rename shared function (both use and implementation of them) so they are not shared
> +// and each library carries its own copy of a implementation, this is needed as

So why are they not appropriately named in the first place?

> +// the fd numbers are not transportable between libs on windows

AFAIK they are, as long as they're linked to the same stdlib (which
probably is the case for libav*).

>  #define avpriv_open ff_open
>  #define avpriv_tempfile ff_tempfile
> +
>  #define PTRDIFF_SPECIFIER "Id"
>  #define SIZE_SPECIFIER "Iu"
>  #else