[FFmpeg-devel] [PATCH v3] avfilter/scale: refactor common code for scaling height/width expressions

[Michael Niedermayer]

On Thu, Feb 02, 2017 at 12:35:45AM +0000, Mark Thompson wrote:
> On 02/02/17 00:30, Aman Gupta wrote:
> > From: Aman Gupta <aman at tmm1.net>
> > 
> > Implements support for height/width expressions in vf_scale_vaapi,
> > by refactoring common code into a new libavfilter/scale.c
> > ---
> >  libavfilter/Makefile         |   8 +--
> >  libavfilter/scale.c          | 152 +++++++++++++++++++++++++++++++++++++++++++
> >  libavfilter/scale.h          |  28 ++++++++
> >  libavfilter/vf_scale.c       | 109 +++----------------------------
> >  libavfilter/vf_scale_npp.c   |  93 +++-----------------------
> >  libavfilter/vf_scale_vaapi.c |  19 ++++--
> >  6 files changed, 216 insertions(+), 193 deletions(-)
> >  create mode 100644 libavfilter/scale.c
> >  create mode 100644 libavfilter/scale.h
> 
> LGTM.  Michael is listed as the maintainer of vf_scale, though, so we should wait for him to look at it before applying.

assuming the code is just moved/factored, sure LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170202/ae142c5b/attachment.sig>