[FFmpeg-devel] [PATCH] mov, matroskadec : Allow matroskadec & mov to share spherical parsing logic.

[James Almer]

On 2/8/2017 10:47 AM, Vittorio Giovara wrote:
> On Mon, Feb 6, 2017 at 4:59 PM, Aaron Colwell <acolwell at google.com> wrote:
>> - Extracts common spherical metadata parsing logic.
>> - Adds checks to enforce that only non-tiled equirect & non-padded cubemaps
>>   are accepted.
> 
> Hi Aaron,
> this patch basically ignores all my comments, so I'm not very happy with it.
> 
> I believe the biggest complaint of mine is that this implementation
> only works with the ffmpeg command line and leaves users in the dark,
> in addition to everything I said in the other thread. There are other
> cosmetics oddities (such as adding a *mov* dependency to the
> *matroska* code

The matroska elements contain the spherical data in the same structure
as they are in mov files. Much like we're including oggdec.h or flac.h
to parse vorbis comment and flac headers, including a new header to
parse an specific kind of mov atom available in other formats should be
ok.

After all, the alternative would be duplicate the parsing code in two
demuxers.

, or mixing code move with new functionality) which are
> practices that should be avoided.
> 
> If you don't mind, I'll try to work on something that should finally
> settle this and provide a patch.
> Cheers
>