[FFmpeg-devel] [PATCH]ffmpeg: Check the return values of two functions

[Nicolas George]

Le quartidi 24 pluviôse, an CCXXV, Marton Balint a écrit :
> Writing a warning about the failed filter functions is good, but ffmpeg has
> a -xerror option as well, so I guess the proper fix would be to propagate
> the error through the functions and fail the encoding process as well if
> -xerror is set.

I hesitated to mention it in my review. Ideally, taking it into account
would be nice. But...

First, our code is not completely consistent in its respect for -xerror,
especially when it comes to filtering, unless I am mistaken. A re-read
of the various code paths would probably be necessary to make all that
consistent.

Second, the patch fixes an issue (annoying warnings) even without that.

So my opinion is that the patch can go in even without the -xerror
implementation. A comment /* TODO -xerror */ would do no harm, though.
And I see the implementation of -xerror elsewhere is really small; but a
bit of factoring would make it more elegant and consistent.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170212/22dad2ea/attachment.sig>