[FFmpeg-devel] [PATCH 2/9] ffmpeg: do packet ts rescaling in write_packet()

[Michael Niedermayer]

On Mon, Feb 13, 2017 at 06:27:50AM +0100, wm4 wrote:
> On Fri, 10 Feb 2017 22:43:26 +0100
> Michael Niedermayer <michael at niedermayer.cc> wrote:
> 
> > On Fri, Feb 10, 2017 at 01:35:34PM +0100, wm4 wrote:
> > > From: Anton Khirnov <anton at khirnov.net>
> > > 
> > > This will be useful in the following commit, after which the muxer
> > > timebase is not always available when encoding.
> > > 
> > > This merges Libav commit 3e265ca. It was previously skipped.
> > > 
> > > There is a minor change with setting the mux_timebase field only after
> > > the muxer's write_header function has been called, because it can
> > > readjust the timebase.
> > > 
> > > Includes a minor merge fix by Mark Thompson.
> > > 
> > > Signed-off-by: wm4 <nfxjfg at googlemail.com>
> > > ---
> > >  ffmpeg.c | 39 ++++++++++++++++++++++-----------------
> > >  ffmpeg.h |  2 ++
> > >  2 files changed, 24 insertions(+), 17 deletions(-)  
> > 
> > Is this intended to result in no changes ?
> > 
> > ./ffmpeg -ss 15 -i ~/tickets/1332/Starship_Troopers.vob  -scodec dvbsub  -vcodec copy -t 4 -r 24000/1001 -an aaa.ts
> > differs from before and after this patch
> > 
> > [...]
> 
> Is it different in a good or a bad way?

I did not do a analysis of the difference.
My concern are the growing number of regressions (which implies more
get added than fixed). And so i try to find changes and issues in
patches before they are pushed.

I wish to work on the many past regressions and fix at least some
of them, i just realized we have some regressions that are caused by
commits i did long ago. These are things i want to look into and i
seem not to have as much time as i want. Analysing differences other
peoples patches on the ML cause is not something i would be able to do
without not doing something else that i feel iam more responsble for


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170214/7f3208dc/attachment.sig>