[FFmpeg-devel] [PATCH v2 1/8] ffmpeg: make sure packets put into the muxing FIFO are refcounted

[Michael Niedermayer]

On Wed, Feb 15, 2017 at 10:24:16AM +0100, wm4 wrote:
> Some callers (like do_subtitle_out()) call this with an AVPacket that is
> not refcounted. This can cause undefined behavior.
> 
> Calling av_packet_move_ref() does not make a packet refcounted if it
> isn't yet. (And it can't be made to, because it always succeeds,
> and can't return ENOMEM.)
> 
> Call av_packet_ref() instead to make sure it's refcounted.
> 
> I couldn't find a case that is fixed by this with the current code. But
> it will fix the fate-pva-demux test with the later patches applied.
> 
> Signed-off-by: wm4 <nfxjfg at googlemail.com>

couldnt find anything that this (cb6f1be864c64cfa1d48a5d3eadbecbc771402e7) breaks

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170222/c1df3d10/attachment.sig>