[FFmpeg-devel] [PATCH] avcodec: add ClearVideo decoder

[Paul B Mahol]

On 2/25/17, James Almer <jamrial at gmail.com> wrote:
> On 2/25/2017 1:22 PM, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>> Only I-frames for now.
>> ---
>>  doc/general.texi        |   1 +
>>  libavcodec/Makefile     |   1 +
>>  libavcodec/allcodecs.c  |   1 +
>>  libavcodec/avcodec.h    |   1 +
>>  libavcodec/clearvideo.c | 388
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>  libavcodec/codec_desc.c |   7 +
>>  libavformat/riff.c      |   1 +
>>  libavformat/rm.c        |   1 +
>>  8 files changed, 401 insertions(+)
>>  create mode 100644 libavcodec/clearvideo.c
>
> Don't forget the version bump and changelog entry.

OK

>> +/*
>> + * ClearVideo decoder
>> + * Copyright (c) 2012 Konstantin Shishkov
>
> You didn't touch it at all?

Only some marginal stuff.

>
>> +            skip = get_bits(gb, 6);
>> +            val  = get_bits(gb, 8);
>> +            val  = sign_extend(val, 8);
>
> Use get_sbits()
>

Done.

>> +    } else {
>> +    }
>
> Remnant of deleted code?

Missing code to handle P-frames.