[FFmpeg-devel] [PATCH v7] - Added Turing codec interface for ffmpeg

[Saverio Blasi]

Dear Mark,

We provide our custom Boost libraries. In our tests we are able to build and run using just "--enable-gpl --enable-libturing". We would prefer to keep the pkgconfig file. I am not sure I fully understand what is required to be changed there (if anything), could you please be a bit more specific?

Thanks a lot,
Saverio

-----Original Message-----
From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of Mark Thompson
Sent: 27 February 2017 11:14
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v7] - Added Turing codec interface for ffmpeg

On 27/02/17 08:29, Saverio Blasi wrote:
>> Right, I had a bit more of a look at it and was able to "fix" it by adding the boost libraries to the ffmpeg configure line as well.
>>
>> Actually running it it all looks good to me, if as fast as a particularly lethargic snail (like all H.265 encoders targetting quality).
>>
>> valgrind came up with some errors, but they appear to be on the libturing side rather than in the ffmpeg wrapper (i.e. please do fix them, but they don't matter to this patch).
>>
>> Thanks,
>>
>> - Mark
>
> Dear Mark,
>
> Thanks a lot for this, we are very happy to know the patch will be integrated.
> Regarding the problems you mention, we will have a look at the output of valgrind, and are also working on speeding up the encoder.

Also the pkgconfig file:
* It refers to the libturing build directory, which need not exist after installation.
* I think libstdc++ and the boost libraries are always required, not just when linking statically.  (Not sure how this interacts with other parts, though - it seems to not like the system boost libraries on Ubuntu 16.04 (1.58): do you need to install your custom boost libraries as well?)

It should be possible to build and run with just "--enable-gpl --enable-libturing" on a clean "make install"ed libturing.

Thanks,

- Mark

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


-----------------------------
http://www.bbc.co.uk
This e-mail (and any attachments) is confidential and
may contain personal views which are not the views of the BBC unless specifically stated.
If you have received it in
error, please delete it from your system.
Do not use, copy or disclose the
information in any way nor act in reliance on it and notify the sender
immediately.
Please note that the BBC monitors e-mails
sent or received.
Further communication will signify your consent to
this.
-----------------------------