[FFmpeg-devel] [PATCH] avcodec/texturedspenc: Fix indexing in color distribution determination

[Michael Niedermayer]

On Tue, Jan 03, 2017 at 02:15:20PM +0100, Vittorio Giovara wrote:
> On Mon, Jan 2, 2017 at 2:00 AM, James Almer <jamrial at gmail.com> wrote:
> > On 1/1/2017 8:28 PM, Michael Niedermayer wrote:
> >> Fixes CID1396405
> 
> What is the CID about?

sorry for not quoting this prviously, it isnt very interresting.
my patch is based on just this and guesswork, which is why it should
be tested.

257        for (y = 0; y < 4; y++) {
   assignment: Assigning: x = 4.
   const: At condition x < 4, the value of x must be equal to 4.
   dead_error_condition: The condition x < 4 cannot be true.
258            for (x = 4; x < 4; x += 4) {
   CID 1396405 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin: Execution cannot reach this statement: muv += bp[x * 4 + y * stride];.
259                muv += bp[x * 4 + y * stride];
260                if (bp[x] < minv)
261                    minv = bp[x * 4 + y * stride];
262                else if (bp[x] > maxv)
263                    maxv = bp[x * 4 + y * stride];
264            }
265        }


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170104/9d38eaf7/attachment.sig>