[FFmpeg-devel] [PATCHv3] add signature filter for MPEG7 video signature

[Gerion Entrup]

On Dienstag, 3. Januar 2017 16:58:32 CET Moritz Barsnick wrote:
> > > The English opposite of "fine" is "coarse", not "course". :)
> > Oops.
> 
> You still have a few "courses". (The actual variables, not the types. I
> don't care *too* much, but might be better for consistency.)
You're right. Fixed version attached.


> From my side - mostly style and docs - it looks fine. Technically, I
> can't judge too much. You went through a long review cycle already, so
> I assume it's fine for those previous reviewers. They have the last
> call anyway.

What about FATE? I'm willing to write a test, but don't know the best way. 
There are official conditions, whether the signature is standard compliant. I've 
written a python script to proof that (see previous emails). Nevertheless the 
checks take relatively long and need 3GB inputvideo, so I assume this is not 
usable for FATE.

One way would be, to take a short input video, take the calculated signature 
and use this as reference, but the standard allow some bitflips and my code
has some of them in comparison to the reference signatures.

Gerion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: changes.diff
Type: text/x-patch
Size: 13408 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170104/c0b8fd8e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-signature-filter-for-MPEG7-video-signature.patch
Type: text/x-patch
Size: 81528 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170104/c0b8fd8e/attachment-0001.bin>