[FFmpeg-devel] [PATCH] avformat: Add rtp_mpegtsraw (MPEG-TS RAW Stream output)

[Andreas Håkon]

Hi Moritz,


-------- Original Message --------
Subject: Re: [FFmpeg-devel] [PATCH] avformat: Add rtp_mpegtsraw (MPEG-TS RAW Stream output)
From: barsnick at gmx.net
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>

On Fri, Jan 13, 2017 at 07:57:28 -0500, Andreas Håkon wrote:
> +static int rtp_mpegtsraw_write_close(AVFormatContext *s)
> +{

ffmpeg bracket style is different.


The bracket style is identical to the rest of the ffmpeg code... !?


> + struct MuxChain *chain = s->priv_data;
> + int ret = AVERROR(ENOMEM);
> + ret = rtp_mpegts_write_header(s);

Why would you assign a value to ret which you immediately discard?


Fixed.


> + avformat_free_context(chain->mpegts_ctx);
> +
> + chain->mpegts_ctx = NULL;

Indentation is inconsistent, throughout the patch BTW.


Fixed.


> + int ret = 0;
> +
> + ret = av_write_frame(chain->rtp_ctx, pkt);

Same here with the assignment.


Fixed too.

Updated patch attached.
A.H.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-avformat-Add-rtp_mpegtsraw-MPEG-TS-RAW-Stream-output.patch.txt
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170115/706a8555/attachment.txt>