[FFmpeg-devel] [PATCH 1/2] avfilter: change ff_inlink_make_frame_writable() to take AVFrame* argument

[wm4]

On Sun, 29 Jan 2017 13:00:38 +0100
Nicolas George <george at nsup.org> wrote:

> Le decadi 10 pluviôse, an CCXXV, wm4 a écrit :
> > His 1/2 patch was a strict improvement over the current internal API.
> > In particular, it gets it into line with the current
> > av_frame_make_writable() API.  
> 
> You purposefully ignore the fact, already stated, that moving away from
> av_frame_make_writable() was intentional.

Then  you should stop moving away from it. The av_frame_make_writable
design is superior for multiple reasons, and was intentionally designed
this way by an intelligent mind with a lot of API-foresight.

If you "move away from it" just like this, you create a major
inconsistency as well.

I haven't heard a good argument as to why its API is supposed to be
better than av_frame_make_writable.

I one the other hand delivered a bunch of arguments to which you didn't
reply.