[FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

[Clément Bœsch]

On Tue, Jan 31, 2017 at 07:45:56AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Jan 30, 2017 at 8:52 PM, Andreas Cadhalpun <
> andreas.cadhalpun at googlemail.com> wrote:
> 
> > Marton proposed a way to mitigate this [1], but you haven't commented
> > on it so far.
> 
> 
> It doesn't mitigate it. Source code is still an issue, as is binary size if
> CONFIG_SMALL is off, which is the default for release builds.
> 
> Even if you change CONFIG_SMALL to NDEBUG, the source code issue is still
> there.
> 
> I don't want this patch. I also don't want to discuss it further. Please
> remove the log message. Thank you.
> 

I stayed silent on the issue so far, but I'm with Ronald on this one and
don't want to pollute functional code with elaborated error code paths
unlikely to happen.

I understand every con and pro from both sides and don't plan to comment
again on the topic.

Regards,

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170131/91c7a53b/attachment.sig>