[FFmpeg-devel] [PATCH] Add FITS Decoder
Nicolas George
george at nsup.org
Tue Jul 4 12:27:41 EEST 2017
Le quartidi 14 messidor, an CCXXV, Paras Chadha a écrit :
> Made all the changes suggested
> Added a new function which reads a header FITS line safely. It also makes it more modular
> Added an option for the user to enter the value to be used in place of BLANK pixels
> Refactored code using macros to make it short
Note: this is the commit message, it is there to stay, so it must
contain information about the whole commit, not its differences with a
previous draft of it. These, and any other kind of comment, belong
between the first triple-dash line and the beginning of the actual diff,
where Git places the shortstats of the diff.
Also, lines should be split way below 80 characters.
>
> Signed-off-by: Paras Chadha <paraschadha18 at gmail.com>
> ---
> Changelog | 1 +
> doc/general.texi | 2 +
> libavcodec/Makefile | 1 +
> libavcodec/allcodecs.c | 1 +
> libavcodec/avcodec.h | 1 +
> libavcodec/codec_desc.c | 8 +
> libavcodec/fitsdec.c | 505 ++++++++++++++++++++++++++++++++++++++++++++++++
> libavcodec/version.h | 4 +-
> libavformat/img2.c | 1 +
> 9 files changed, 522 insertions(+), 2 deletions(-)
> create mode 100644 libavcodec/fitsdec.c
Note: before reviewing the code, I think the boundary between the
demuxer and the decoder needs to be properly defined. See my comments in
this mail, near the end:
https://ffmpeg.org/pipermail/ffmpeg-devel/2017-July/213157.html
Regards,
--
Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170704/1e5b483f/attachment.sig>
More information about the ffmpeg-devel
mailing list