[FFmpeg-devel] [PATCH] avformat/hlsenc: add warning message when use fmp4 and byte range mode

[Steven Liu]

2017-07-06 23:31 GMT+08:00 Derek Buitenhuis <derek.buitenhuis at gmail.com>:
> On 7/6/2017 3:55 AM, Steven Liu wrote:
>> +    if (hls->segment_type == SEGMENT_TYPE_FMP4 && byterange_mode) {
>> +        av_log(s, AV_LOG_WARNING, "Have not support fmp4 byterange mode yet now, patch "
>> +               "welcome or wait to support it, change the hls_segment_type to mpegts now.\n");
>> +        hls->segment_type = SEGMENT_TYPE_MPEGTS;
>> +    }
>
> It should hard-fail, and definitely not just continue on with MPEG-TS segments. That's
> really unexpected behavior for a user.
>
> It should return AVERROR_PATCHWELCOME, probably.
ok, merge it.
>
> Do you have plans to implement the functionality in the future?
Yes, but these days i'm busy, will fix it later.
>
> Cheers,
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel