[FFmpeg-devel] [RFC][PATCH] movenc: write clap tag

[Dave Rice]

> On Jul 6, 2017, at 9:39 PM, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> 
> On 7/7/2017 2:20 AM, Dave Rice wrote:
>> Currently this patch writes the clap atom under this condition "track->par->codec_id == AV_CODEC_ID_RAWVIDEO & track->mode == MODE_MOV”; however, AV_CODEC_ID_RAWVIDEO isn’t quite what the spec asks for. Any advice on how to write this condition for “uncompressed Y´CbCr data formats”; for instance v210 is considered uncompress Y´CbCr in QuickTime but is not a AV_CODEC_ID_RAWVIDEO. I haven’t found a concise way to add a condition for uncompressed YUV.
> 
> First, it should be '&&', I assume.

Thanks.

> I don't think there's any concise way of checking such conditions... you'll
> probably have to do something like a list of "codes" (v410, v210, raw) and
> some sort of sanity check for track->par->format to confirm is is YCbCr.
> Maybe someone knows better than myself.

I see that although it’s mandatory for uncompressed YUV, there’s no constraint to not use it otherwise, so I think I’ll proceed with just a check for MODE_MOV. I just checked ffmbc’s movenc.c and it also only checks for MODE_MOV.
Dave Rice