[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

[Daniel Kučera]

2017-06-02 3:31 GMT+02:00 Michael Niedermayer <michael at niedermayer.cc>:
> On Thu, Jun 01, 2017 at 01:12:13PM +0200, Daniel Kucera wrote:
>> Signed-off-by: Daniel Kucera <daniel.kucera at gmail.com>
>> ---
>>  libavformat/aviobuf.c | 18 ++++++++++--------
>>  1 file changed, 10 insertions(+), 8 deletions(-)
>
> breaks fate (infinte loops)
> example fate-swr-resample-s32p-2626-8000
>

Thanks Michael.
Now I'm trying to pass fate. I've fixed some problems but don't have
an idea why it won't pass following test. Does anyone have idea?

TEST    seek-cache-pipe
./tests/fate-run.sh fate-seek-cache-pipe "fate-suite/" ""
"/home/danman/FFmpeg" 'cat fate-suite//gapless/gapless.mp3 | run
libavformat/tests/seek cache:pipe:0 -read_ahead_limit -1' ''
'./tests/ref/seek/cache-pipe' '' '3' '' '' '' '' '' '' '' '' ''
 /home/danman/FFmpeg/libavformat/tests/seek cache:pipe:0 -read_ahead_limit -1
--- ./tests/ref/seek/cache-pipe    2017-05-23 17:02:08.517401755 +0200
+++ tests/data/fate/seek-cache-pipe    2017-06-02 14:30:41.555138153 +0200
@@ -6,21 +6,19 @@
 ret: 0         st: 0 flags:0  ts: 0.788334
 ret: 0         st: 0 flags:1 dts: 0.809796 pts: 0.809796 pos:  14407
size:   418
 ret:-1         st: 0 flags:1  ts:-0.317499
-ret: 0         st:-1 flags:0  ts: 2.576668
-ret: 0         st: 0 flags:1 dts: 2.586122 pts: 2.586122 pos:  42828
size:   418
+ret:-1         st:-1 flags:0  ts: 2.576668
 ret: 0         st:-1 flags:1  ts: 1.470835
 ret: 0         st: 0 flags:1 dts: 1.462857 pts: 1.462857 pos:  24856
size:   418
 ret: 0         st: 0 flags:0  ts: 0.365002
 ret: 0         st: 0 flags:1 dts: 0.365714 pts: 0.365714 pos:   7302
size:   418
 ret:-1         st: 0 flags:1  ts:-0.740831
-ret: 0         st:-1 flags:0  ts: 2.153336
-ret: 0         st: 0 flags:1 dts: 2.168163 pts: 2.168163 pos:  36141
size:   418
+ret:-1         st:-1 flags:0  ts: 2.153336
 ret: 0         st:-1 flags:1  ts: 1.047503
 ret: 0         st: 0 flags:1 dts: 1.044898 pts: 1.044898 pos:  18169
size:   418
 ret: 0         st: 0 flags:0  ts:-0.058330
 ret: 0         st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos:   1451
size:   417
 ret: 0         st: 0 flags:1  ts: 2.835837
-ret: 0         st: 0 flags:1 dts: 2.821224 pts: 2.821224 pos:  46590
size:   418
+ret: 0         st: 0 flags:1 dts: 1.933061 pts: 1.933061 pos:  32380
size:   388
 ret: 0         st:-1 flags:0  ts: 1.730004
 ret: 0         st: 0 flags:1 dts: 1.750204 pts: 1.750204 pos:  29454
size:   418
 ret: 0         st:-1 flags:1  ts: 0.624171
@@ -28,7 +26,7 @@
 ret: 0         st: 0 flags:0  ts:-0.481662
 ret: 0         st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos:   1451
size:   417
 ret: 0         st: 0 flags:1  ts: 2.412505
-ret: 0         st: 0 flags:1 dts: 2.403265 pts: 2.403265 pos:  39903
size:   418
+ret: 0         st: 0 flags:1 dts: 1.933061 pts: 1.933061 pos:  32380
size:   388
 ret: 0         st:-1 flags:0  ts: 1.306672
 ret: 0         st: 0 flags:1 dts: 1.332245 pts: 1.332245 pos:  22766
size:   418
 ret: 0         st:-1 flags:1  ts: 0.200839
@@ -36,12 +34,11 @@
 ret: 0         st: 0 flags:0  ts:-0.904994
 ret: 0         st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos:   1451
size:   417
 ret: 0         st: 0 flags:1  ts: 1.989173
-ret: 0         st: 0 flags:1 dts: 1.985306 pts: 1.985306 pos:  33215
size:   418
+ret: 0         st: 0 flags:1 dts: 1.933061 pts: 1.933061 pos:  32380
size:   388
 ret: 0         st:-1 flags:0  ts: 0.883340
 ret: 0         st: 0 flags:1 dts: 0.888163 pts: 0.888163 pos:  15661
size:   418
 ret:-1         st:-1 flags:1  ts:-0.222493
-ret: 0         st: 0 flags:0  ts: 2.671674
-ret: 0         st: 0 flags:1 dts: 2.690612 pts: 2.690612 pos:  44500
size:   418
+ret:-1         st: 0 flags:0  ts: 2.671674
 ret: 0         st: 0 flags:1  ts: 1.565841
 ret: 0         st: 0 flags:1 dts: 1.541224 pts: 1.541224 pos:  26110
size:   418
 ret: 0         st:-1 flags:0  ts: 0.460008
Test seek-cache-pipe failed. Look at
tests/data/fate/seek-cache-pipe.err for details.
[cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38
[cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38
[mp3 @ 0x56224fd44040] invalid concatenated file detected - using
bitrate for duration
[cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38
[cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38
[cache @ 0x56224fd448e0] Inner protocol failed to seekback end : -38
[cache @ 0x56224fd448e0] Statistics, cache hits:0 cache misses:8
tests/Makefile:221: recipe for target 'fate-seek-cache-pipe' failed
make: *** [fate-seek-cache-pipe] Error 1


Thank you.

S pozdravom / Best regards
Daniel Kucera.