[FFmpeg-devel] [PATCH 3/3] avformat/aviobuf: increase buffer size to 128k

[Marton Balint]

On Mon, 5 Jun 2017, Michael Niedermayer wrote:

> On Sun, Jun 04, 2017 at 03:35:07PM +0200, Marton Balint wrote:
>> Another huge performance improvement when using SMB/CIFS as output.
>>
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>>  libavformat/aviobuf.c     | 2 +-
>>  tests/ref/seek/lavf-alaw  | 3 +--
>>  tests/ref/seek/lavf-mulaw | 3 +--
>>  3 files changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c
>> index 7d1b385253..36eb093a3a 100644
>> --- a/libavformat/aviobuf.c
>> +++ b/libavformat/aviobuf.c
>> @@ -33,7 +33,7 @@
>>  #include "url.h"
>>  #include <stdarg.h>
>>
>> -#define IO_BUFFER_SIZE 32768
>> +#define IO_BUFFER_SIZE 131072
>>
>
> this is changed for all protocols not just the ones tested.
> also i remember some patch that changes te buffer size for some
> protocols, not sure what happened to that.
> and theres the short_seek stuff, it might make sense to adjust that
> too

A less intrusive approach is to set the buffer size for the file protocol 
only and only if a file is opened for writing. In that case, the fate 
test resuls will remain the same as well.

Regards,
Marton