[FFmpeg-devel] [PATCH 1/2] libavfilter/scale: More descriptive in/ref/out logging

[Michael Niedermayer]

On Mon, Jun 05, 2017 at 06:55:20AM -0400, Kevin Mark wrote:
> This change makes it more clear when using the scale and scale2ref
> filters what is actually happening. The old format did not
> differentiate between scale and scale2ref which would make it seem
> that, when using scale2ref, the ref was what was truly being scaled.
> 
> Old format for both scale and scale2ref:
> 
> w:640 h:360 fmt:rgb24 sar:1/1 -> w:160 h:120 fmt:rgb24 sar:4/3 flags:0x2
> 
> The left side is the input and the right side is the output. While
> this is sufficiently clear for scale, for scale2ref it appears to
> conflate the main input with the reference input. To be fair that is
> exactly what the code is doing (and on purpose) but that's not a very
> intuitive implementation detail to expose to the user. Now that the
> main input's constants are exposed in scale2ref it makes even more
> sense to correct this.
> 
> New format for scale:
> 
> in  w:320 h:240 fmt:rgb24 sar:1/1
> out w:80 h:60 fmt:rgb24 sar:1/1 flags:0xc0000
> 
> New format for scale2ref:
> 
> in  w:320 h:240 fmt:rgb24 sar:1/1
> ref w:640 h:360 fmt:rgb24 sar:1/1
> out w:160 h:120 fmt:rgb24 sar:4/3 flags:0x2
> 
> The increase in clarity is self-evident.

yes but its much harder to grep for as its not a single line anymore

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170606/73707aca/attachment.sig>